[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Split up platfrom specifics from bridge driver



On Thu, Jul 04, 2013 at 08:25:32PM +0400, Roman Bogorodskiy wrote:
> * Functions were renamed: s/Iptables/Firewall/
>   to make names more general.
> * Platform specific things (e.g. firewalling and route
>   collision checks) were moved into bridge_driver_platform
> * Created two platform specific implementations:
>    - bridge_driver_linux: Linux implementation using iptables,
>      it's actually the code moved from bridge_driver.c
>    - bridge_driver_noop: dump implementation that does nothing
> ---
>  po/POTFILES.in                       |    1 +
>  src/Makefile.am                      |    5 +-
>  src/network/bridge_driver.c          |  729 +---------------------------------
>  src/network/bridge_driver_linux.c    |  709 +++++++++++++++++++++++++++++++++
>  src/network/bridge_driver_noop.c     |   80 ++++
>  src/network/bridge_driver_platform.c |   32 ++
>  src/network/bridge_driver_platform.h |   77 ++++
>  7 files changed, 915 insertions(+), 718 deletions(-)
>  create mode 100644 src/network/bridge_driver_linux.c
>  create mode 100644 src/network/bridge_driver_noop.c
>  create mode 100644 src/network/bridge_driver_platform.c
>  create mode 100644 src/network/bridge_driver_platform.h

ACK, this is pretty much the approach we discussed on IRC.

Will let Eric look at it before pushing though, in case he
disagrees with this approach.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]