[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 02/37] Introduce OOM reporting to virAsprintf



On 07/09/13 17:09, Michal Privoznik wrote:
Actually, I'm turning this function into a macro as filename,
function name and line number needs to be passed. The new
function virAsprintfInternal is introduced with the extended set
of arguments.
---
  cfg.mk                            |  2 +-
  src/conf/domain_audit.c           | 36 ++++++++++-----------
  src/driver.c                      |  4 +--
  src/libvirt_private.syms          |  4 +--
  src/util/virerror.c               |  2 +-
  src/util/virlog.c                 | 16 +++++-----

you resolved my most critical comments.

  src/util/virstring.c              | 36 ++++++++++++---------
  src/util/virstring.h              | 67 +++++++++++++++++++++++++++++++++++----
  tests/domainsnapshotxml2xmltest.c |  2 ++
  tests/fchosttest.c                |  2 ++
  tests/interfacexml2xmltest.c      |  2 ++
  tests/lxcxml2xmltest.c            |  2 ++
  tests/networkxml2xmltest.c        |  2 ++
  tests/nodedevxml2xmltest.c        |  2 ++
  tests/nodeinfotest.c              |  2 ++
  tests/nwfilterxml2xmltest.c       |  2 ++
  tests/qemuargv2xmltest.c          |  2 ++
  tests/qemuhelptest.c              |  2 ++
  tests/qemuxml2xmltest.c           |  2 ++
  tests/sexpr2xmltest.c             |  2 ++
  tests/storagepoolxml2xmltest.c    |  2 ++
  tests/storagevolxml2argvtest.c    |  2 ++
  tests/storagevolxml2xmltest.c     |  2 ++
  tests/sysinfotest.c               |  2 ++
  tests/virbuftest.c                |  2 ++
  tests/virhashtest.c               |  2 ++
  tests/virshtest.c                 |  2 ++
  tests/xencapstest.c               |  2 ++
  tests/xml2sexprtest.c             |  2 ++
  tools/virt-host-validate-common.c |  2 ++
  30 files changed, 158 insertions(+), 53 deletions(-)


ACK.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]