[libvirt] [PATCH] Fix crash when multiple event callbacks were registered
Daniel P. Berrange
berrange at redhat.com
Wed Jul 10 11:02:01 UTC 2013
On Wed, Jul 10, 2013 at 12:59:48PM +0200, Ján Tomko wrote:
> CVE-2013-2230
This should be in the subject line so it is more visible.
> Don't overwrite the callback ID returned by
> virDomainEventStateRegisterID in ret by 0.
>
> Introduced by abf75aea.
> ---
> src/qemu/qemu_driver.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 571d1f8..b0180c9 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -10043,9 +10043,7 @@ qemuConnectDomainEventRegisterAny(virConnectPtr conn,
> driver->domainEventState,
> dom, eventID,
> callback, opaque, freecb, &ret) < 0)
> - goto cleanup;
> -
> - ret = 0;
> + ret = -1;
>
> cleanup:
> return ret;
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list