[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix crash when multiple event callbacks were registered



On 07/10/2013 12:59 PM, Ján Tomko wrote:
> CVE-2013-2230
> 
> Don't overwrite the callback ID returned by
> virDomainEventStateRegisterID in ret by 0.
> 
> Introduced by abf75aea.
> ---
>  src/qemu/qemu_driver.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 571d1f8..b0180c9 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -10043,9 +10043,7 @@ qemuConnectDomainEventRegisterAny(virConnectPtr conn,
>                                        driver->domainEventState,
>                                        dom, eventID,
>                                        callback, opaque, freecb, &ret) < 0)
> -        goto cleanup;
> -
> -    ret = 0;
> +        ret = -1;
>  
>  cleanup:
>      return ret;
> 

ACK,

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]