[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 06/10] Add capability to fetch balloon stats



On Mon, Jul 08, 2013 at 03:20:32PM -0400, John Ferlan wrote:
> This patch will add the QEMU_MONITOR_OBJECT_PROPERTY_BALLOON_STATS type and
> a mechanism in the qemuMonitorObjectProperty to fetch and store an opaque
> data array assuming that we are provided a count of current elements,
> a count of maximum elements, and the address of the array store the data.
> Use the mechanism to fetch balloon driver statistics.
> ---
>  src/qemu/qemu_monitor.c      |   3 +-
>  src/qemu/qemu_monitor_json.c | 206 ++++++++++++++++++++-----------------------
>  src/qemu/qemu_monitor_json.h |   5 ++
>  3 files changed, 103 insertions(+), 111 deletions(-)



> +int qemuMonitorJSONGetMemoryStats(qemuMonitorPtr mon,
> +                                  char *balloonpath,
> +                                  virDomainMemoryStatPtr stats,
> +                                  unsigned int nr_stats)

Given the level of changes in this function, can you also add a
test case for it in qemumonitorjsontest.c. It is hard to tell from
the code that it is actually doing what is is intended to do.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]