[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] deadlock in function storageVolLookupByKey and storageVolLookupByPath



Hello,

On 07/13/2013 03:59 AM, Caizhifeng wrote:
> root cvknode-141:~/libvirt1.1.0# diff storage_driver.c storage_driver-new.c
> 1364c1364,1365
> <                 if (virStorageVolLookupByKeyEnsureACL(conn, driver->pools.objs[i]->def, vol) < 0)
> ---
>>                 if (virStorageVolLookupByKeyEnsureACL(conn, driver->pools.objs[i]->def, vol) < 0) {
>>                     virStoragePoolObjUnlock(driver->pools.objs[i]);
> 1365a1367
>>                 }
> 1371a1374
>>                 virStoragePoolObjUnlock(driver->pools.objs[i]);
> 1424c1427,1428
> <                 if (virStorageVolLookupByPathEnsureACL(conn, driver->pools.objs[i]->def, vol) < 0)
> ---
>>                 if (virStorageVolLookupByPathEnsureACL(conn, driver->pools.objs[i]->def, vol) < 0) {
>>                     virStoragePoolObjUnlock(driver->pools.objs[i]);
> 1425a1430
>>                 }
> 1431a1437
>>                 virStoragePoolObjUnlock(driver->pools.objs[i]);
> root cvknode-141:~/libvirt1.1.0#

This has been fixed already:
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=fe89fd3b

Please use 'git send-email' when sending patches, as suggested on:
http://libvirt.org/hacking.html

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]