[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 1/2] pci: reorder static functions



On 07/15/2013 04:39 AM, Martin Kletzander wrote:
> On 07/01/2013 07:46 PM, Laine Stump wrote:
>> virPCIDeviceGetDriverPathAndName is a static function that will need
>> to be called by another function that occurs above it in the
>> file. This patch reorders the static functions so that a forward
>> declaration isn't needed.
>> ---
>>  src/util/virpci.c | 177 +++++++++++++++++++++++++++---------------------------
>>  1 file changed, 90 insertions(+), 87 deletions(-)
>>
> Most of the time I was looking for those 3 lines added, but found out
> those are blanks.  Pure movement, ACK.

It would be really cool if git could be taught to show movement of
complete functions in some more compact manner (similar to what it does
when you rename a file). No idea exactly what that would look like though...

Thanks for the review. I'll push as soon as I rebase and re-compile.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]