[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 4/7] storage_pool: Rework chap XML to mimic ceph



On Mon, Jul 15, 2013 at 09:04:32AM -0400, John Ferlan wrote:
> The existing 'chap' XML logic was never used - just defined.  Rather than
> try to insert a square peg into a round hole, blow it up and rewrite the
> logic to follow the 'ceph' format.
> 
> Remove the former "chap.login" and "chap.passwd" fields and replace
> with "chap.username" and "chap.secret" in _virStoragePoolAuthChap.
> Adjust the virStoragePoolDefParseAuthChap() to process.
> 
> Change the rng file to describe the new layout
> 
> Update the formatstorage.html to describe the usage of the secret element
> to mention that the secret type "iscsi" and "ceph" can be used
> to storage pool too.
> 
> Update the formatsecret.html to include a reference to the storage pool
> 
> Update tests to handle the changes from 'login' and 'passwd' to 'username'
> and '<secret>' format
> ---
>  docs/formatsecret.html.in                          | 10 ++--
>  docs/formatstorage.html.in                         | 25 +++++++++-
>  docs/schemas/storagepool.rng                       | 20 ++------
>  src/conf/storage_conf.c                            | 56 +++++++++++++++-------
>  src/conf/storage_conf.h                            |  4 +-
>  tests/storagepoolxml2xmlin/pool-iscsi-auth.xml     |  4 +-
>  .../pool-iscsi-vendor-product.xml                  |  4 +-
>  tests/storagepoolxml2xmlout/pool-iscsi-auth.xml    |  4 +-
>  .../pool-iscsi-vendor-product.xml                  |  4 +-
>  tests/storagepoolxml2xmlout/pool-rbd.xml           |  2 +-
>  10 files changed, 87 insertions(+), 46 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]