[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 6/7] storage_conf: Merge AuthChap and AuthCephx into AuthSecret



On Mon, Jul 15, 2013 at 09:04:34AM -0400, John Ferlan wrote:
> Merge virStoragePoolDefParseAuthChap and virStoragePoolDefParseAuthCephx
> into a common virStoragePoolDefParseAuthSecret.  Change the output to be
> common for both by putting 'type' first followed by 'username'.
> 
> Need to adjust a test output for that too.

Didn't seem like you had to - unles the test change was mistakenly
added to a different commit in this series ?

> ---
>  src/conf/storage_conf.c | 60 ++++++++++---------------------------------------
>  1 file changed, 12 insertions(+), 48 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]