[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4] Make logical pools independent on target path



On Mon, Jul 15, 2013 at 04:29:54PM +0200, Martin Kletzander wrote:
> When using logical pools, we had to trust the target->path provided.
> This parameter, however, can be completely ommited and we can use
> '/dev/<source.name>' safely and populate it to target.path.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=952973
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
> 
> Notes:
>     v4:
>      - Don't add anything complicated, just rely on /dev/VG_NAME/LV_NAME
>     v3:
>      - just rebase
>     v2:
>      - don't drop pool's target.path, but fix it instead to /dev/VG_NAME
> 
>  docs/schemas/storagepool.rng                       | 13 ++++++++++++-
>  src/conf/storage_conf.c                            | 17 ++++++++++++-----
>  src/storage/storage_backend_logical.c              | 22 +++-------------------
>  src/storage/storage_driver.c                       |  2 +-
>  tests/storagepoolxml2xmlin/pool-logical-create.xml |  2 +-
>  tests/storagepoolxml2xmlin/pool-logical-nopath.xml | 19 +++++++++++++++++++
>  .../storagepoolxml2xmlout/pool-logical-nopath.xml  | 22 ++++++++++++++++++++++
>  tests/storagepoolxml2xmltest.c                     |  1 +
>  8 files changed, 71 insertions(+), 27 deletions(-)
>  create mode 100644 tests/storagepoolxml2xmlin/pool-logical-nopath.xml
>  create mode 100644 tests/storagepoolxml2xmlout/pool-logical-nopath.xml

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]