[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 05/10] Determine whether to start balloon memory stats gathering.



On Fri, Jul 12, 2013 at 10:40:01AM -0400, John Ferlan wrote:
> On 07/12/2013 08:39 AM, Daniel P. Berrange wrote:
> > On Thu, Jul 11, 2013 at 07:55:55PM -0400, John Ferlan wrote:
> >> At vm startup and attach attempt to set the balloon driver statistics
> >> collection period based on the value found in the domain xml file. This
> >> is not done at reconnect since it's possible that a collection period
> >> was set on the live guest and making the set period call would reset to
> >> whatever value is stored in the config file.
> >>
> >> Setting the stats collection period has a side effect of searching through
> >> the qom-list output for the virtio balloon driver and making sure that it
> >> has the right properties in order to allow setting of a collection period
> >> and eventually fetching of statistics.
> >>
> >> The walk through the qom-list is expensive and thus the balloonpath will
> >> be saved in the monitor private structure as well as a flag indicating
> >> that the initialization has already been attempted (in the event that a
> >> path is not found, no sense to keep checking).
> >>
> >> This processing model conforms to the qom object model model which
> >> requires setting object properties after device startup. That is, it's
> >> not possible to pass the period along via the startup code as it won't
> >> be recognized.
> >> ---
> >>  src/qemu/qemu_monitor.c      | 130 +++++++++++++++++++++++++++++++++++++++++++
> >>  src/qemu/qemu_monitor.h      |   2 +
> >>  src/qemu/qemu_monitor_json.c |  24 ++++++++
> >>  src/qemu/qemu_monitor_json.h |   3 +
> >>  src/qemu/qemu_process.c      |  14 ++++-
> >>  5 files changed, 171 insertions(+), 2 deletions(-)

> 
> I've squashed the following in:

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]