[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 10/10] Allow balloon driver collection to be adjusted dynamically



On Fri, Jul 12, 2013 at 10:41:23AM -0400, John Ferlan wrote:
> On 07/12/2013 08:45 AM, Daniel P. Berrange wrote:
> > On Thu, Jul 11, 2013 at 07:56:00PM -0400, John Ferlan wrote:
> <...snip...>
> 
> 
> >> index 5fbd32c..4cbf105 100644
> >> --- a/tools/virsh-domain-monitor.c
> >> +++ b/tools/virsh-domain-monitor.c
> >> @@ -314,6 +314,23 @@ static const vshCmdOptDef opts_dommemstat[] = {
> >>       .flags = VSH_OFLAG_REQ,
> >>       .help = N_("domain name, id or uuid")
> >>      },
> >> +    {.name = "period",
> >> +     .type = VSH_OT_DATA,
> >> +     .flags = VSH_OFLAG_EMPTY_OK,
> >> +     .help = N_("period in seconds to set collection")
> >> +    },
> > 
> > Hmm, I think I'd prefer to see the 'period' specified as a flag,
> > rather than positional arg. eg
> > 
> >   virsh dommemstat --period NNN
> > 
> 
> I've squashed the following:
> 
> diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
> index 4cbf105..773f96d 100644
> --- a/tools/virsh-domain-monitor.c
> +++ b/tools/virsh-domain-monitor.c
> @@ -316,7 +316,7 @@ static const vshCmdOptDef opts_dommemstat[] = {
>      },
>      {.name = "period",
>       .type = VSH_OT_DATA,
> -     .flags = VSH_OFLAG_EMPTY_OK,
> +     .flags = VSH_OFLAG_REQ_OPT,
>       .help = N_("period in seconds to set collection")
>      },
>      {.name = "config",


Need to update the .pod man page to say I<--period> too.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]