[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rbd: Do not free the secret if it is not set



On 07/16/2013 02:26 PM, Wido den Hollander wrote:
> Not all RBD (Ceph) storage pools have cephx authentication turned on,
> so "secret" might not be initialized.
> 
> It could also be that the secret couldn't be located.
> 
> Only call virSecretFree() if "secret" is initialized earlier.
> 
> Signed-off-by: Wido den Hollander <wido widodh nl>
> ---
>  src/storage/storage_backend_rbd.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

ACK

I've removed the extra braces and pushed it.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]