[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Split up platfrom specifics from bridge driver



On 07/04/2013 10:25 AM, Roman Bogorodskiy wrote:
> This is a second step for making bridge_driver more portable.

This finally percolated to the top of my todo list; I'll have a review
shortly.

> 
> This one splits up bridge driver into platform specific and general
> parts. Platform specifc parts are mostly firewalling stuff.
> 
> So the support for new platforms should be added by implementing
> bridge_driver_$platform.c 
> 
> However, you might notice I didn't move some ports of the 
> platform specific code. E.g. I left networkEnableIpForwarding
> in bridge_driver.c because it feels like the implementation for 
> e.g. all BSDs would be the same (while firewalling stuff would
> be different on BSDs) to avoid code copy/paste.


> 
> Roman Bogorodskiy (1):
>   Split up platfrom specifics from bridge driver
> 
>  po/POTFILES.in                       |    1 +
>  src/Makefile.am                      |    5 +-
>  src/network/bridge_driver.c          |  729 +---------------------------------
>  src/network/bridge_driver_linux.c    |  709 +++++++++++++++++++++++++++++++++
>  src/network/bridge_driver_noop.c     |   80 ++++
>  src/network/bridge_driver_platform.c |   32 ++
>  src/network/bridge_driver_platform.h |   77 ++++
>  7 files changed, 915 insertions(+), 718 deletions(-)

Looks big, but the bulk of it is code motion, so it should be reasonable.

>  create mode 100644 src/network/bridge_driver_linux.c
>  create mode 100644 src/network/bridge_driver_noop.c
>  create mode 100644 src/network/bridge_driver_platform.c
>  create mode 100644 src/network/bridge_driver_platform.h
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]