[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: split long lines



On 17.07.2013 19:51, Eric Blake wrote:
> Long lines are harder to read and harder to diff; in fact, if lines get
> too long (> 1000 bytes), it starts causing issues where git send-email
> refuses to send patches for the file.  I've cleaned up the tests
> directory in the past (see commits bd6c46f, 3b750d1), but new long
> lines have been introduced in the meantime.
> 
> Victim files found with:
> $ wc -L tests/qemuxml2argvdata/*.args | sort -k1,1n \
>   | sed -n '/\b\(9[0-9]\|[1-9][0-9][0-9]\)\b/p'
> 
> * tests/qemuxml2argvdata/qemuxml2argv-*.args: Split lines of any
> file with content longer than 90 columns.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---

Maybe it's great time to bring up discussion on maximal line length. I
mean, if we can size it up. I usually work on wide angle monitor and
even if I :vsplit (bring up two vim windows next to each other) there's
still plenty of space left.

> 
> Whitespace-only, but it's big enough that I'll wait for comments
> before pushing.
> 
>  .../qemuxml2argv-boot-complex-bootindex.args              | 15 ++++++++++-----
>  tests/qemuxml2argvdata/qemuxml2argv-boot-complex.args     |  6 ++++--
>  tests/qemuxml2argvdata/qemuxml2argv-boot-order.args       |  9 ++++++---
>  .../qemuxml2argvdata/qemuxml2argv-console-virtio-ccw.args |  3 ++-
>  tests/qemuxml2argvdata/qemuxml2argv-controller-order.args |  8 +++++---
>  .../qemuxml2argv-cpu-host-model-fallback.args             |  3 ++-
>  tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-tray.args  |  6 ++++--
>  .../qemuxml2argvdata/qemuxml2argv-disk-copy_on_read.args  | 12 ++++++++----
>  .../qemuxml2argvdata/qemuxml2argv-disk-drive-discard.args |  9 ++++++---
>  .../qemuxml2argv-disk-drive-network-gluster.args          |  8 +++++++-
>  .../qemuxml2argv-disk-drive-network-iscsi-auth.args       |  7 ++++++-
>  .../qemuxml2argv-disk-drive-network-iscsi.args            |  9 ++++++++-
>  tests/qemuxml2argvdata/qemuxml2argv-disk-ioeventfd.args   |  9 ++++++---
>  tests/qemuxml2argvdata/qemuxml2argv-disk-order.args       |  6 ++++--
>  .../qemuxml2argv-disk-scsi-disk-split.args                | 12 ++++++++----
>  .../qemuxml2argvdata/qemuxml2argv-disk-scsi-disk-wwn.args |  6 ++++--
>  .../qemuxml2argv-disk-scsi-lun-passthrough.args           |  6 ++++--
>  tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-vscsi.args  | 10 ++++++----
>  .../qemuxml2argv-disk-virtio-scsi-ccw.args                |  6 ++++--
>  .../qemuxml2argv-disk-virtio-scsi-num_queues.args         |  3 ++-
>  tests/qemuxml2argvdata/qemuxml2argv-event_idx.args        |  9 ++++++---
>  .../qemuxml2argv-graphics-spice-agentmouse.args           |  9 ++++++---
>  .../qemuxml2argv-graphics-spice-timeout.args              |  6 ++++--
>  .../qemuxml2argv-graphics-spice-usb-redir.args            | 11 ++++++++---
>  tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.args   |  6 ++++--
>  .../qemuxml2argvdata/qemuxml2argv-hostdev-scsi-boot.args  |  3 ++-
>  tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi.args |  6 ++++--
>  .../qemuxml2argv-hostdev-scsi-readonly.args               |  3 ++-
>  .../qemuxml2argv-hostdev-scsi-virtio-scsi.args            |  3 ++-
>  .../qemuxml2argv-input-usbmouse-addr.args                 |  6 +++++-
>  tests/qemuxml2argvdata/qemuxml2argv-pseries-basic.args    |  8 +++++++-
>  .../qemuxml2argv-pseries-vio-user-assigned.args           |  6 ++++--
>  tests/qemuxml2argvdata/qemuxml2argv-pseries-vio.args      |  6 ++++--
>  tests/qemuxml2argvdata/qemuxml2argv-tpm-passthrough.args  |  3 ++-
>  tests/qemuxml2argvdata/qemuxml2argv-usb-controller.args   |  6 +++++-
>  tests/qemuxml2argvdata/qemuxml2argv-usb-hub.args          |  7 ++++++-
>  tests/qemuxml2argvdata/qemuxml2argv-usb-ports.args        | 11 ++++++++++-
>  tests/qemuxml2argvdata/qemuxml2argv-usb-redir-filter.args | 14 ++++++++++----
>  tests/qemuxml2argvdata/qemuxml2argv-usb-redir.args        |  8 ++++++--
>  tests/qemuxml2argvdata/qemuxml2argv-virtio-lun.args       |  6 ++++--
>  tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-ccw.args   |  3 ++-
>  tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-egd.args   |  8 +++++++-
>  42 files changed, 216 insertions(+), 85 deletions(-)
> 

But till then, ACK this fits our coding style better.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]