[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 8/9] Remove lxcDriverLock from almost everywhere



On Wed, Jul 17, 2013 at 03:04:25PM +0200, Michal Privoznik wrote:
> With the majority of fields in the virLXCDriverPtr struct
> now immutable or self-locking, there is no need for practically
> any methods to be using the LXC driver lock. Only a handful
> of helper APIs now need it.
> ---
>  src/lxc/lxc_conf.c    |  14 ++++-
>  src/lxc/lxc_conf.h    |   3 -
>  src/lxc/lxc_driver.c  | 171 +++++---------------------------------------------
>  src/lxc/lxc_process.c |  14 +----
>  4 files changed, 27 insertions(+), 175 deletions(-)

ACK

> diff --git a/src/lxc/lxc_conf.h b/src/lxc/lxc_conf.h
> index f8caebe..a6208a2 100644
> --- a/src/lxc/lxc_conf.h
> +++ b/src/lxc/lxc_conf.h
> @@ -76,9 +76,6 @@ struct _virLXCDriver {
>       * lockless access thereafter */
>      virCapsPtr caps;
>  
> -     /* Immutable pointer. Unsafe APIs XXX */
> -    virCgroupPtr cgroup;
> -
>      /* Immutable pointer, Immutable object */
>      virDomainXMLOptionPtr xmlopt;
>  

This ought to be in a dedicated patch.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]