[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: add qemu.conf option to disable PCI passthrough



On Thu, Jul 18, 2013 at 12:52:56PM +0200, Ján Tomko wrote:
> ---
> 
> Note: virPCIProbeStubDriver is currently broken because of 2f8babc,
> I've sent a fix:
> https://www.redhat.com/archives/libvir-list/2013-July/msg01154.html
> 
>  src/qemu/libvirtd_qemu.aug         | 1 +
>  src/qemu/qemu.conf                 | 5 +++++
>  src/qemu/qemu_conf.c               | 2 ++
>  src/qemu/qemu_conf.h               | 2 ++
>  src/qemu/qemu_hostdev.c            | 8 ++++++++
>  src/qemu/test_libvirtd_qemu.aug.in | 1 +
>  6 files changed, 19 insertions(+)
> 
> diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug
> index 5344125..62399fa 100644
> --- a/src/qemu/libvirtd_qemu.aug
> +++ b/src/qemu/libvirtd_qemu.aug
> @@ -53,6 +53,7 @@ module Libvirtd_qemu =
>                   | str_array_entry "cgroup_controllers"
>                   | str_array_entry "cgroup_device_acl"
>                   | int_entry "seccomp_sandbox"
> +                 | bool_entry "pci_passthrough"
>  
>     let save_entry =  str_entry "save_image_format"
>                   | str_entry "dump_image_format"


Why do we need this non-feature ?  If you don't want pci passthrough
then just don't use it. We don't need global config params to disble
arbitrary guest device types like this.

NACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]