[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/3] Convert cgroups code to report errors



From: "Daniel P. Berrange" <berrange redhat com>

Since the viralloc.h methods were changed to report errors, the
cgroups code's approach of returning errno values is even less
sensible than it was before. This series changes the cgroups code
to report errors throughout.

As a general point, I think we should have a goal of eliminating
the use of 'return -errno' in all libvirt code, since it will let
us provide more accurate error messages.

Daniel P. Berrange (3):
  Report full errors from virCgroupNew*
  Convert the virCgroupKill* APIs to report errors
  Convert remainder of cgroups code to report errors

 src/libvirt_private.syms |    1 +
 src/lxc/lxc_cgroup.c     |   83 ++--
 src/lxc/lxc_container.c  |    6 +-
 src/lxc/lxc_fuse.c       |    6 +-
 src/lxc/lxc_process.c    |   15 +-
 src/qemu/qemu_cgroup.c   |   87 ++--
 src/qemu/qemu_driver.c   |   76 +---
 src/util/vircgroup.c     | 1136 +++++++++++++++++++++++++---------------------
 src/util/virerror.c      |   46 ++
 src/util/virerror.h      |    4 +
 tests/vircgrouptest.c    |   44 +-
 11 files changed, 784 insertions(+), 720 deletions(-)

-- 
1.8.1.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]