[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Check for link_addr more thoroughly



On Thu, Jul 18, 2013 at 07:04:13AM -0600, Eric Blake wrote:
> On 07/18/2013 03:11 AM, Guido Günther wrote:
> > Some versions of kFreeBSD (like 9.0) declare link_addr in a header
> > but lack an implementation. This makes ./configure pass but breaks
> > compilation later with a
> > 
> >      undefined reference to `link_addr'
> > 
> > Althought that's a bug in the OS header we can detect it easily by also
> > trying to link.
> > 
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=715320
> > ---
> > Changes from v1:
> > 
> >     Use AC_LINK_IFELSE instead of AC_TRY_LINK
> 
> Thanks; ACK.
Pushed. Thanks.

> 
> > 
> > I used AC_TRY_LINK since it's used in other places in configure.ac.
> > Should these be converted too?
> 
> Sure, that's a reasonable cleanup, but as a separate patch.
I'll add that to my backlog.
Cheers,
 -- Guido

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]