[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Use AC_LINK_IFELSE



On Thu, Jul 18, 2013 at 10:59:06AM -0600, Eric Blake wrote:
> On 07/18/2013 10:44 AM, Guido Günther wrote:
> > instead of the deprecated AC_TRY_LINK
> > ---
> >  configure.ac | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> ACK.
> 
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 5d5c8de..0f0b265 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -893,13 +893,14 @@ if test "$with_libvirtd" = "no" ; then
> >    with_lxc=no
> >  fi
> >  if test "$with_lxc" = "yes" || test "$with_lxc" = "check"; then
> > -    AC_TRY_LINK([
> > +    AC_LINK_IFELSE([AC_LANG_PROGRAM(
> > +    [[
> >          #include <sched.h>
> >          #include <linux/loop.h>
> >          #include <sys/epoll.h>
> > -    ], [
> > +    ]], [[
> >          unshare (!(LO_FLAGS_AUTOCLEAR + EPOLL_CLOEXEC));
> 
> As long as you're touching this, remove the space before '('.

Pushed with that change. Thanks,
 -- Guido

> 
> > -    ], [
> > +    ]])], [
> >          with_lxc=yes
> >         AC_DEFINE([HAVE_DECL_LO_FLAGS_AUTOCLEAR], [1],
> >           [Define to 1 if you have the declaration of `LO_FLAGS_AUTOCLEAR',
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]