[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: split long lines in Makefiles



On 18.07.2013 17:42, Eric Blake wrote:
> Makefiles are another easy file to enforce line limits.
> 
> Mostly straightforward; interesting tricks worth noting:
> src/Makefile.am: $(confdir) was already defined, use it in more places
> tests/Makefile.am: path_add and VG required some interesting compression
> 
> * cfg.mk (sc_prohibit_long_lines): Add another test.
> * Makefile.am:Fix offenders.
> * daemon/Makefile.am: Likewise.
> * docs/Makefile.am: Likewise.
> * python/Makefile.am: Likewise.
> * src/Makefile.am: Likewise.
> * tests/Makefile.am: Likewise.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
> 
> Should be no change in behavior, but needs a review :)
> 
>  Makefile.am        |  9 +++++---
>  cfg.mk             |  4 ++++
>  daemon/Makefile.am | 21 ++++++++++++------
>  docs/Makefile.am   | 15 +++++++++----
>  python/Makefile.am | 18 ++++++++++------
>  src/Makefile.am    | 63 +++++++++++++++++++++++++++++++++---------------------
>  tests/Makefile.am  | 25 +++++++++++++++-------
>  7 files changed, 103 insertions(+), 52 deletions(-)

ACK

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]