[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Add helpers for dealing with system errors



On 07/19/2013 08:14 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Add virErrorSetErrnoFromLastError and virLastErrorIsSystemErrno
> to simplify code which wants to handle system errors in a more
> graceful fashion.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/libvirt_private.syms |  1 +
>  src/util/virerror.c      | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  src/util/virerror.h      |  4 ++++
>  3 files changed, 53 insertions(+)
> 
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 5d39d50..a2b61c7 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -1318,6 +1318,7 @@ ebtablesRemoveForwardAllowIn;
>  # util/virerror.h
>  virDispatchError;
>  virErrorInitialize;
> +virLastErrorIsSystemErrno;
>  virRaiseErrorFull;
>  virReportErrorHelper;
>  virReportOOMErrorFull;

Don't you also need to export virErrorSetErrnoFromLastError?

> +
> +/**
> + * virLastErrorIsSystemErrno:
> + * @errnum: the errno value
> + *
> + * Check if the last error reported is a system
> + * error with the specific errno value.
> + *
> + * If @errnum is zero, any system error will pass.
> + *
> + * Returns true if the last errr was a system error with errno == @errnum

s/errr/error/

ACK with those fixes.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]