[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] qemu: Unplug devices that disappeared when libvirtd was down



On Mon, Jul 22, 2013 at 11:13:30 +0200, Peter Krempa wrote:
> On 07/19/13 19:00, Jiri Denemark wrote:
> > In case libvirtd is asked to unplug a device but the device is actually
> > unplugged later when libvirtd is not running, we need to detect that and
> > remove such device when libvirtd starts again and reconnects to running
> > domains.
> > ---
> >   src/qemu/qemu_domain.c  | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
> >   src/qemu/qemu_domain.h  |  4 ++++
> >   src/qemu/qemu_driver.c  |  6 ++++++
> >   src/qemu/qemu_process.c | 43 +++++++++++++++++++++++++++++++++++++
> >   4 files changed, 109 insertions(+)
> >
> 
> ...
> 
> > diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
> > index 2f3b141e..9a959d6 100644
> > --- a/src/qemu/qemu_domain.h
> > +++ b/src/qemu/qemu_domain.h
> > @@ -171,6 +171,7 @@ struct _qemuDomainObjPrivate {
> >
> >       virCond unplugFinished; /* signals that unpluggingDevice was unplugged */
> >       const char *unpluggingDevice; /* alias of the device that is being unplugged */
> > +    char **qemuDevices; /* NULL-terminated list of devices aliases known to QEMU */
> 
> s/devices/device/ || s/devices/devices'/
> 
> >   };
> >
> >   typedef enum {
> 
> ACK.

Oops, I pushed the series but forgot to do this change :-/ Anyway,
thanks for the reivew.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]