[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 0/7] Support to use iscsi storage in domain conf



On 07/19/2013 08:32 AM, John Ferlan wrote:
> An update to yesterday's posting:
> 
> https://www.redhat.com/archives/libvir-list/2013-July/msg01213.html
> 
> Changes in v3 over v2
>  * Update patch 1 per code review
>  * Use 'direct' instead of 'uri' and supporting documentaiton
>  * In patch 4, use qemuAddISCSIPoolSourceHost() instead of
>    qemuAddDiskISCSIUri.  Also added a check in the function 
>    that (pooldef->source.nhost != 1) to make sure we at least
>    have a host defined in the pool and of course that there's
>    only one.
> 
> 
> John Ferlan (5):
>   storage_iscsi: Reflect the default target port
>   conf: Introduce new XML tag "mode" for disk source
>   conf: Introduce virDomainDiskSourceIsBlockType
>   qemu: Translate the iscsi pool/volume disk source
>   tests: Add various network and volume definitions
> 
> Osier Yang (2):
>   conf: Ignore the volume type disk if its mode is "direct"
>   qemu: Translate the volume type disk source before cgroup setting
> 
>  docs/formatdomain.html.in                          |  11 +-
>  docs/schemas/domaincommon.rng                      |   8 ++
>  src/conf/domain_conf.c                             |  67 ++++++++++-
>  src/conf/domain_conf.h                             |  26 +++++
>  src/libvirt_private.syms                           |   1 +
>  src/qemu/qemu_command.c                            |  20 +++-
>  src/qemu/qemu_conf.c                               | 124 +++++++++++++++++----
>  src/qemu/qemu_process.c                            |  13 ++-
>  src/storage/storage_backend_iscsi.c                |  19 ++--
>  .../qemuxml2argv-disk-source-pool-mode.xml         |  48 ++++++++
>  tests/qemuxml2xmltest.c                            |   1 +
>  tests/securityselinuxlabeldata/netdisks.txt        |   5 +
>  tests/securityselinuxlabeldata/netdisks.xml        |  58 ++++++++++
>  tests/securityselinuxlabeldata/voldisks.txt        |   5 +
>  tests/securityselinuxlabeldata/voldisks.xml        |  45 ++++++++
>  tests/securityselinuxlabeltest.c                   |   2 +
>  16 files changed, 414 insertions(+), 39 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-source-pool-mode.xml
>  create mode 100644 tests/securityselinuxlabeldata/netdisks.txt
>  create mode 100644 tests/securityselinuxlabeldata/netdisks.xml
>  create mode 100644 tests/securityselinuxlabeldata/voldisks.txt
>  create mode 100644 tests/securityselinuxlabeldata/voldisks.xml
> 

I pushed patches 1-4, 6, & 7.  Will wait for more feedback on 5.

Thanks for the reviews.

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]