[libvirt] [PATCH] qemu: Take error path if acquiring of job fails in qemuDomainSaveInternal

Peter Krempa pkrempa at redhat.com
Tue Jul 23 14:36:20 UTC 2013


On 07/23/13 16:26, Jiri Denemark wrote:
> On Tue, Jul 23, 2013 at 16:21:10 +0200, Peter Krempa wrote:
>> Due to a goto statement missed when refactoring in 2771f8b74c1bf50d1fa
>> when acquiring of a domain job failed the error path was not taken. This
>> resulted into a crash afterwards as a extra reference was removed from a
>
> s/as a/as an/
>
>> domain object leading to it being freed. An attempt to list the domains
>> afterwards leaded to a crash of the daemon afterwards.
>
> ETOOMANYATERWARDS :-P
>
>> https://bugzilla.redhat.com/show_bug.cgi?id=928672

...

>
> ACK with the commit message polished.

I upgraded the message and pushed the patch afterwards ;)

>
> Jirka

Thanks.

Peter




More information about the libvir-list mailing list