[libvirt] [PATCH 01/13] Fix handling of DBus errors emitted by the bus itself

Daniel P. Berrange berrange at redhat.com
Tue Jul 23 15:21:06 UTC 2013


From: "Daniel P. Berrange" <berrange at redhat.com>

Current code for handling dbus errors only works for errors
received from the remote application itself. We must also
handle errors emitted by the bus itself, for example, when
it fails to spawn the target service.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 src/util/virdbus.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/util/virdbus.c b/src/util/virdbus.c
index 6221bdc..9b0977a 100644
--- a/src/util/virdbus.c
+++ b/src/util/virdbus.c
@@ -1129,9 +1129,8 @@ int virDBusCallMethod(DBusConnection *conn,
                                                             call,
                                                             VIR_DBUS_METHOD_CALL_TIMEOUT_MILLIS,
                                                             &error))) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Cannot send to %s.%s on path %s with interface %s: %s"),
-                       destination, member, path, interface, NULLSTR(error.message));
+        virReportDBusServiceError(error.message ? error.message : "unknown error",
+                                  error.name);
         goto cleanup;
     }
 
-- 
1.8.1.4




More information about the libvir-list mailing list