[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/5] conf: add pcie-root controller



On Tue, Jul 23, 2013 at 10:44:55AM -0400, Laine Stump wrote:
> This controller is implicit on q35 machinetypes. It provides 31 PCIe
> (*not* PCI) slots as controller 0.
> 
> Currently there are no devices that can connect to pcie-root. For a
> usable q35 system, we still need to add a "dmi-to-pci-bridge" pci
> controller, which can connect to pcie-root, and provides pci slots.
> 
> This patch still requires a test case, which willbe coming up, but I
> wanted to include it along with the previous patch to show that it's
> simpler to add new controller types now.
> ---
>  docs/formatdomain.html.in | 17 ++++++++++++++---
>  src/conf/domain_conf.c    |  4 +++-
>  src/conf/domain_conf.h    |  1 +
>  src/qemu/qemu_command.c   | 17 +++++++++++++----
>  src/qemu/qemu_command.h   |  2 ++
>  src/qemu/qemu_domain.c    | 23 +++++++++++++++++------
>  6 files changed, 50 insertions(+), 14 deletions(-)

ACK once test case(s) are added.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]