[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/7] cpu: Add support for loading and storing CPU data



On Tue, Jul 23, 2013 at 17:27:41 +0100, Daniel Berrange wrote:
> On Tue, Jul 23, 2013 at 06:11:30PM +0200, Jiri Denemark wrote:
> 
> Could use a more verbose commit message.
> 
> Looking at later patches, I see cpuDataFormat used in the
> test suite, but I don't see cpuDataParse used anywhere ?
> If these are only for the test suite, then perhaps adding
> them to a cpupriv.h header is preferrable.

Yeah, cpupriv.h might be better since both APIs are really there just
for our testsuite. Although I guess marking them as testsuite only in
cpu.h would work too. And you're right, cpuDataParse is not used
anywhere but I plan to use it in other cpu related tests in the future
and having them both in a single patch seemed best to me.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]