[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/13] Create + setup cgroups atomically for QEMU process



On 07/23/2013 09:21 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Currently the QEMU driver creates the VM's cgroup prior to
> forking, and then uses a virCommand hook to move the child
> into the cgroup. This won't work with systemd whose APIs
> do the creation of cgroups + attachment of processes atomically.
> 
> Fortunately we have a handshake taking place between the
> QEMU driver and the child process prior to QEMU being exec()d,
> which was introduced to allow setup of disk locking. By good
> fortune this synchronization point can be used to enable the
> QEMU drivedr to do atomic setup of cgroups removing the use

s/drivedr/driver/

> of the hook script.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/qemu/qemu_cgroup.c  | 12 +++++++++---
>  src/qemu/qemu_process.c | 39 +++++++++++++++++----------------------
>  2 files changed, 26 insertions(+), 25 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]