[libvirt] [PATCH 11/13] Convert LXC driver to use virCgroupNewMachine
Eric Blake
eblake at redhat.com
Tue Jul 23 21:56:37 UTC 2013
On 07/23/2013 09:21 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Convert the LXC driver code to use the new atomic API
> for setup of cgroups
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/lxc/lxc_cgroup.c | 53 +++++++++++++++---------------------------------
> src/lxc/lxc_controller.c | 2 +-
> 2 files changed, 17 insertions(+), 38 deletions(-)
> + /*
> + * XXX
> + * We should pass the PID of the LXC init process
> + * not ourselves, but this requires some more
> + * refactoring. We should also pass the root dir
> + */
> + if (virCgroupNewMachine(def->name,
> + "lxc",
> + true,
> + def->uuid,
> + NULL,
> + getpid(),
The comment sounded a bit ominous about passing wrong information; but
as long as it's not permanently getting us into a setup where we can't
recover, but just represents an inefficiency, I don't think it hurts to
make incremental progress.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130723/9eeab63b/attachment-0001.sig>
More information about the libvir-list
mailing list