[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Don't overwrite errors in qemuTranslateDiskSourcePool



On 07/24/2013 03:47 AM, Ján Tomko wrote:
> Both virStoragePoolFree and virStorageVolFree reset the last error,
> which might lead to the cryptic message:
> An error occurred, but the cause is unknown
> 
> When the volume wasn't found, virStorageVolFree was called with NULL,
> leading to an error:
> invalid storage volume pointer in virStorageVolFree
> 
> This patch changes it to:
> Storage volume not found: no storage vol with matching name 'tomato'
> ---
> v1: https://www.redhat.com/archives/libvir-list/2013-July/msg01522.html
> v2: only save/restore the error when ret < 0
> 
>  src/qemu/qemu_conf.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]