[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] Use separate macros for failure/success in vol-to-argv test



On 07/25/2013 12:29 AM, Eric Blake wrote:
> On 07/22/2013 08:52 AM, Ján Tomko wrote:
>> Reindent them to put the input volume on a separate line.
>> ---
>>  tests/storagevolxml2argvtest.c | 64 +++++++++++++++++++++++++++++-------------
>>  1 file changed, 44 insertions(+), 20 deletions(-)
>>
>> diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c
>> index 89c233f..4f4bf7d 100644
>> --- a/tests/storagevolxml2argvtest.c
>> +++ b/tests/storagevolxml2argvtest.c
>> @@ -161,7 +161,8 @@ mymain(void)
>>      int ret = 0;
>>      unsigned int flags = VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA;
>>  
>> -#define DO_TEST(shouldFail, pool, vol, inputvol, cmdline, flags, imgformat) \
>> +#define DO_TEST_FULL(shouldFail, pool, vol, inputvol, cmdline, flags, \
>> +                     imgformat) \
> 
> Is it worth lining up the \ to a single column?  But that's cosmetic, I
> don't care if you do that or not.
> 
> ACK.
> 

I've lined them up and pushed the series.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]