[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] qemu: refactor qemuDomainCheckDiskPresence for only disk presence check



On 07/18/2013 01:32 PM, Guannan Ren wrote:
> Refactor this function to make it focus on disk presence checking,
> including diskchain checking, and not only for CDROM and Floppy.
> This change is good for the following patches.
> ---
>  src/qemu/qemu_domain.c | 99 ++++++++++++++++++++++++++++++--------------------
>  1 file changed, 59 insertions(+), 40 deletions(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 06efe14..1fa1a5f 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -1989,6 +1989,61 @@ cleanup:
>      virObjectUnref(cfg);
>  }
>  
> +static int
> +qemuDomainCheckDiskStartupPolicy(virQEMUDriverPtr driver,
> +                                 virDomainObjPtr vm,
> +                                 virDomainDiskDefPtr disk,
> +                                 int startupPolicy,

No need for this parameter as you have it in the disk already.

ACK with that fixed, clean code movement.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]