[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] Remove redundant free in virNetworkDNSHostDefParseXML



On 26.07.2013 12:28, Ján Tomko wrote:
> ip has to be NULL at this point.
> ---
>  src/conf/network_conf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
> index 2561c35..2040d26 100644
> --- a/src/conf/network_conf.c
> +++ b/src/conf/network_conf.c
> @@ -859,7 +859,6 @@ virNetworkDNSHostDefParseXML(const char *networkName,
>          virReportError(VIR_ERR_XML_DETAIL,
>                         _("Missing IP address in network '%s' DNS HOST record"),
>                         networkName);
> -        VIR_FREE(ip);
>          goto error;
>      }
>  
> 

ACK

Increasing context size would show the line just above these where we
can clearly see without need to open the network_conf.c that @ip has to
be NULL to take this path. Nevermind.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]