[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Resolve Coverity complaint in storagevolxml2argvtest



On 07/26/2013 01:42 PM, John Ferlan wrote:
> On 07/26/2013 07:27 AM, Ján Tomko wrote:
>> Ignore NULL pool in testSetVolumeType to silence Coverity,
>> even though we only call it with NULL pool when vol is also NULL.
>>
>> (13) Event var_deref_model:	Passing null pointer "inputpool" to
>> function "testSetVolumeType(virStorageVolDefPtr, virStoragePoolDefPtr)",
>> which dereferences it. [details]
>> Also see events: [assign_zero]
>>
>> 95    testSetVolumeType(inputvol, inputpool);
>> ---
>>  tests/storagevolxml2argvtest.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> 
> ACK.
> 
> I ran the coverity analysis and it's happy.
> 

Yay!

Pushed.

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]