[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix probing of legacy Xen driver to not leave URI set



On 07/26/2013 10:30 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> When the legacy Xen driver probes with a NULL URI, and
> finds itself running on Xen, it will set conn->uri. A
> little bit later though it checks to see if libxl support
> exists, and if so declines the driver. This leaves the
> conn->uri set to 'xen:///', so if libxl also declines
> it, it prevents probing of the QEMU driver.
> 
> Once a driver has set the conn->uri, it must *never*
> decline an open request. So we must move the libxl
> check earlier
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/xen/xen_driver.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]