[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] build: yet another cgroup conditional compilation fix



On 07/29/2013 09:09 AM, Daniel P. Berrange wrote:
> On Mon, Jul 29, 2013 at 08:53:35AM -0600, Eric Blake wrote:
>> From: "Daniel P. Berrange" <berrange redhat com>
>>

>>
>> -static int virCgroupPartitionEscape(char **path);
>> -
>>  bool virCgroupAvailable(void)
>>  {
>>      bool ret = false;
>> @@ -95,6 +93,10 @@ bool virCgroupAvailable(void)
>>      return ret;
>>  }
>>
>> +#if defined HAVE_MNTENT_H && defined HAVE_GETMNTENT_R
>> +
>> +static int virCgroupPartitionEscape(char **path);
>> +

> 
> This won't apply to master, since I pushed my previous version of
> the patch before you posted about the mingw32 problems

So I noticed.  But all I did that yours didn't do was move the static
declaration into the conditional, to shut up the compiler warning about
an unused static forward declaration.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]