[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API



On Mon, Jul 29, 2013 at 17:48:15 +0100, Daniel Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear
> to be used in the QEMU code anyway. It also doesn't make much
> (any) sense, since the 'shutdown' state is a transient state
> between 'running' and 'shutoff' which is only used by the Xen
> driver.
> 
> It was added in commit 14e7e0ae8db9843aea80245a3d9e6cf5f2ef720d
> which post-dates v1.1.0, so is safe to remove before 1.1.1

The "shutdown" state is actually also used by the QEMU driver with the
same semantics as in the Xen driver. However, if a domain crashed than
it's shutoff and not somewhere between running and shutoff.

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]