[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/20] qemumonitortestutils: Use consistent header style and line spacing



On 07/30/2013 07:05 AM, Peter Krempa wrote:
> ---
>  tests/qemumonitortestutils.c | 62 +++++++++++++++++++++++++++++---------------
>  1 file changed, 41 insertions(+), 21 deletions(-)

Thanks for separating cosmetic from functional changes.

ACK.

> @@ -440,12 +456,14 @@ static qemuMonitorCallbacks qemuCallbacks = {
>      .errorNotify = qemuMonitorTestErrorNotify,
>  };
> 
> +
>  #define QEMU_JSON_GREETING "{\"QMP\": {\"version\": {\"qemu\": {\"micro\": 1, \"minor\": 0, \"major\": 1}, \"package\": \" (qemu-kvm-1.0.1)\"}, \"capabilities\": []}}"

Might be worth splitting this macro long line with \-newline, and
relying on C's implicit concatenation of strings separated only by
whitespace.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]