[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Don't mix commands with macro definitions



On Tue, Jul 30, 2013 at 08:55:53 -0600, Eric Blake wrote:
> On 07/30/2013 08:07 AM, Jiri Denemark wrote:
> > %build section should first define all required macros and then run
> > commands. Interleaving them makes it harder to spot what commands are
> > run.
> > ---
> >  libvirt.spec.in | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> ACK with one observation:

> > @@ -1345,6 +1341,11 @@ of recent versions of Linux (and other OSes).
> >      %endif
> >  %endif
> >  
> 
> Perhaps it deserves a comment here, along the lines of:
> 
> # place macros above and build commands below this comment

Done and pushed, thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]