[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 11/20] qemumonitortestutils: Split lines on \n instead of \r\n



On 07/30/2013 07:05 AM, Peter Krempa wrote:
> The normal monitor uses windows line endings, where the agent monitor
> uses only newlines. Change this to tolerate both approaches and allow to
> use the utilities for guest agent tests.

"windows line endings" are also the proscribed line endings for use in
telnet; it's not an accident that the qemu monitor was designed to be
usable via a telnet connection, and I'm actually a bit surprised that
the qemu agent didn't follow suit.  Might be worth reporting this as an
upstream issue to the qemu list.

> ---
>  tests/qemumonitortestutils.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]