[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 19/20] qemuagenttest: Test arbitrary qemu commands and timeouting of commands



On 07/30/2013 11:27 AM, Eric Blake wrote:
> On 07/30/2013 07:05 AM, Peter Krempa wrote:
>> Test arbitrary qemu commands and timeouting of the guest agent
> 
> s/timeouting/timeouts/ (also in the subject)
> 
>> synchronisation.
>> ---
>>  tests/qemuagenttest.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 101 insertions(+)
> 
> Hmm, I wonder if it's worth adding some sort of escape hatch, maybe if
> 'VIR_TEST_FAST' is defined to non-empty in the environment, then we skip
> this test; developers that don't like the long wait can then export that
> variable as 1, whereas the spec file can ensure it is 0.  That could be
> a followup patch, though, and it might be worth getting more feedback
> than just mine on whether the new long-running test needs tweaking to
> allow developers to avoid waiting, while still avoiding bit-rotting of
> the test at release time.

In testing this patch, I'll point out that I was using new enough
automake that gives us parallel testing, and a command like 'make -j3
check' did not see ANY appreciable delay - we spend more than six
seconds on other tests, such that the sleep time of this new test was
mostly offset by the other tests running in parallel.  Still, it's
probably worth an option for pruning this and other sleeps from the
testsuite when run by a developer.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]