[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Add space before the slash in dns srv entries



On Wed, Jul 31, 2013 at 13:41:42 +0200, Jano Tomko wrote:
> This matches the style for dhcp range/host and dns txt entries.
> 
> nat-network-dns-srv-record{,-minimal}.xml were only used by the
> network schema test. This change allows them to be used unchanged
> by network XML->XML test.
> ---
>  src/conf/network_conf.c    | 2 +-
>  tests/networkxml2xmltest.c | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
> index e3998f3..a0b543c 100644
> --- a/src/conf/network_conf.c
> +++ b/src/conf/network_conf.c
> @@ -2281,7 +2281,7 @@ virNetworkDNSDefFormat(virBufferPtr buf,
>              if (def->srvs[i].weight)
>                  virBufferAsprintf(buf, " weight='%d'", def->srvs[i].weight);
>  
> -            virBufferAddLit(buf, "/>\n");
> +            virBufferAddLit(buf, " />\n");
>          }
>      }
>  

Hmm, shouldn't we rather remove the space from all other places to match
how we normally format XML?

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]