[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/2] add VIR_TEST_EXPENSIVE for faster 'make check' by default

Based on discussion of Peter's recent test additions, and
whether we should sleep waiting for a timeout by default.
I did _not_ wire up the use of VIR_TEST_EXPENSIVE as a way
to bypass Peter's sleep test, although I can help with that
as needed (although in Peter's case, it may be simpler to
just getenv("VIR_TEST_EXPENSIVE") inside the C code, instead
of trying to hack tests/Makefile.am to be conditional).

Tested with 'make distcheck' in both in-tree and VPATH builds
(which also the configure defaults when unpacking a tarball),
and in setups where I explicitly used --enable-gnulib-tests or
--disable-gnulib-tests, vs. running 'make check
VIR_TEST_EXPENSIVE=1'; in all cases, the gnulib tests were
skipped only when expected.

Patch 1/2 is something I noticed on the side (basically
side work from my first approach to compile out the directory
at configure time, but that approach failed 'make check');
patch 2/2 can be applied independently, and this is only a
series because both patches touch configure.

I realized (only now that I am sending this patch) that my
patch is one-way: you can turn on expensive tests (either at
configure time or at runtime) but can't turn them off.
Automake was able to have 'make V=0' and 'make V=1' override
configure defaults in both directions by using nested make
expansion, so if it is deemed necessary, I could respin to
try that approach instead of the approach I used here, where
an explicit VIR_TEST_EXPENSIVE=0 would then disable the tests
regardless of the choice made during configure.  On the other
hand, having only a one-way road for turning on tests, with
no counterpart for turning them off, seems adequate.

I'm also open to bikeshedding, such as whether the configure
options should be named --enable-expensive-tests instead of
--enable-gnulib-tests, on the grounds that we might want
to make tests/Makefile.am conditional after all.

Eric Blake (2):
  maint: use modern autoconf idioms
  build: add configure option to disable gnulib tests

 HACKING                  |  9 ++++++++
 autobuild.sh             |  3 +++
 bootstrap.conf           |  3 ++-
 configure.ac             | 60 ++++++++++++++++++++++++++++++++----------------
 docs/hacking.html.in     | 13 +++++++++++
 gnulib/tests/Makefile.am | 13 ++++++++++-
 libvirt.spec.in          |  1 +
 mingw-libvirt.spec.in    |  4 ++--
 8 files changed, 82 insertions(+), 24 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]