[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Make virNetDevSetupControl() public.



On Sat, May 25, 2013 at 07:07:49AM -0600, Eric Blake wrote:
> On 05/15/2013 11:47 PM, Roman Bogorodskiy wrote:
> > This method is useful not only in virnetdev.c.
> > ---
> >  src/libvirt_private.syms         |  1 +
> >  src/util/virnetdev.c             | 15 +++++++++++++--
> >  src/util/virnetdev.h             | 12 ++++++++++++
> >  src/util/virnetdevmacvlan.c      |  2 +-
> >  src/util/virnetdevvportprofile.c |  2 +-
> >  5 files changed, 28 insertions(+), 4 deletions(-)
> > 
> 
> > +#else
> > +int
> > +virNetDevSetupControl(const char *ifname ATTRIBUTE_UNUSED,
> > +                      void *ifr ATTRIBUTE_UNUSED)
> > +{
> > +    virReportSystemError(ENOSYS,
> > +                         _("%s is not supported on this platform"),
> > +                         __func__);
> 
> virReportSystemError is already a macro that reports the function name,
> so your message would include the name twice.  But offhand, I can't
> think of any better wording to use.

How about

"Network device configuration is not supported on this platform"


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]