[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Reformat listen address prior checking



On 06/05/2013 10:03 AM, Michal Privoznik wrote:

s/prior/prior to/ in the subject

> Currently, a listen address for a SPICE server can be specified. Later,
> when the domain is migrated, we need to relocate the graphics which
> involves telling new destination to the SPICE server. However, we can't
> just assume the listen address is the new location, because the listen
> address can be ANYCAST (0.0.0.0 for IPv4, :: for IPv6). In which case,
> we want to pass the remote hostname. But there are some troubles with
> ANYCAST. In both IPv4 and IPv6 it has many ways for specifying such
> address. For instance, in IPv4: 0, 0.0, 0.0.0, 0.0.0.0.  The number of
> variations gets bigger in IPv6 world. Hence, in order to check for
> ANYCAST address sanely, we should take the provided listen address,
> parse it and format back in it's full form. Which is exactly what this
> patch does.
> ---
>  src/qemu/qemu_migration.c | 18 +++++++++++++++++-
>  tests/sockettest.c        | 24 ++++++++++++++++++++++++
>  2 files changed, 41 insertions(+), 1 deletion(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]