[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4] Assorted bool cleanups



On 05/24/2013 07:02 AM, Ján Tomko wrote:
> Found by: git grep '= 1'
> 
> Ján Tomko (4):
>   Replace two-state local integers with bool
>   Remove redundant two-state integers
>   nwfilter: change two-state int parameters to bool
>   qemu: change two-state int parameters to bool
> 
>  src/conf/domain_conf.c                    | 18 +++++-----
>  src/conf/network_conf.c                   |  5 ++-
>  src/conf/nwfilter_conf.c                  | 56 +++++++++++++++----------------
>  src/conf/storage_conf.c                   |  5 ++-
>  src/lxc/lxc_controller.c                  |  4 +--
>  src/lxc/lxc_process.c                     |  4 +--
>  src/nwfilter/nwfilter_dhcpsnoop.c         |  8 +----
>  src/nwfilter/nwfilter_ebiptables_driver.c | 36 ++++++++++----------
>  src/nwfilter/nwfilter_gentech_driver.c    |  4 +--
>  src/qemu/qemu_agent.c                     |  6 ++--
>  src/qemu/qemu_capabilities.c              | 21 ++++++------
>  src/qemu/qemu_capabilities.h              |  2 +-
>  src/qemu/qemu_command.c                   | 39 ++++++++++-----------
>  src/qemu/qemu_driver.c                    |  6 ++--
>  src/qemu/qemu_hostdev.c                   |  6 ++--
>  src/qemu/qemu_migration.c                 | 20 +++++------
>  src/qemu/qemu_monitor.c                   |  6 ++--
>  src/qemu/qemu_monitor_json.c              |  8 ++---
>  src/qemu/qemu_monitor_text.c              | 16 ++++-----
>  src/qemu/qemu_process.c                   | 23 +++++--------
>  src/remote/remote_driver.c                |  5 ++-
>  src/rpc/virnetserver.c                    |  6 ++--
>  src/storage/storage_backend.c             |  4 +--
>  src/util/vircgroup.c                      |  4 +--
>  src/util/virlog.c                         | 15 +++++----
>  src/util/virnetdev.c                      | 19 +++++------
>  src/util/virpci.c                         | 12 +++----
>  src/util/viruri.c                         |  5 +--
>  src/util/virutil.c                        | 12 +++----
>  tests/qemuhelptest.c                      |  5 +--
>  tests/reconnect.c                         |  6 ++--
>  tests/ssh.c                               |  8 ++---
>  32 files changed, 192 insertions(+), 202 deletions(-)
> 

These look to have been sitting out there for awhile...  Looked through
all seemed fine to me.  Ran through Coverity too without complaints.

ACK

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]