[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] qemu: Prohibit getting the numa parameters if mode is not strict



On 05/24/2013 11:08 AM, Osier Yang wrote:
> I don't see any reason to getting the numa parameters if mode is
> not strict, as long as setNumaParameters doesn't allow to set
> "nodeset" if the mode is not strict, and cpuset.mems only understand
> "strict" mode.
> 

NACK, this makes sense for 'interleave' as well and checking this adds
more code without any special benefits.  This also makes the API fail
when ran with default params even when the caller only wants to know
what mode the domain was started with.  The worst thing that can happen
now is that the caller will not get the second parameter which is OK
(especially when it makes sense).

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]