[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 03/14] qemu: Extract more information about vCPUs and threads

On 06/07/13 15:06, Daniel P. Berrange wrote:
On Wed, Jun 05, 2013 at 03:43:54PM +0200, Peter Krempa wrote:
The qemu monitor provides more information about vCPUs of a guest than
we needed currently. This patch upgrades the extraction function to
easily extract new data about the vCPUs and fixes code to cope with the
new structure. The information extracted here will be later used for
mapping of vCPUs of a guest.

This patch also refactors the function used to parse data from the text
  src/qemu/qemu_driver.c       | 31 ++++++++-------
  src/qemu/qemu_monitor.c      |  9 +++--
  src/qemu/qemu_monitor.h      | 11 +++++-
  src/qemu/qemu_monitor_json.c | 47 +++++++++++++---------
  src/qemu/qemu_monitor_json.h |  2 +-
  src/qemu/qemu_monitor_text.c | 92 +++++++++++++++++++++++++-------------------
  src/qemu/qemu_monitor_text.h |  2 +-
  src/qemu/qemu_process.c      | 63 ++++++++++++++++++++----------
  8 files changed, 159 insertions(+), 98 deletions(-)

I realize this is not new code, but extra bonus points if you
add a case to tests/qemumonitorjsontest.c for the function you
are extending.

Even more bonus points if you fancy creating an equivalent
qemumonitorhmptest.c too.

I don't want to hold up this patch set uneccessarily, but I
think getting tests, particular of the HMP code would be pretty
useful since the parsing code you have is pretty complex.

ACK anyway. Tests can be done as a followup ontop of this series.

Thanks for the review. This patch actually is necessary only for the new cpu mapping API so I didn't push it right now and will repost the rest of the series including the tests.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]