[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remote: fix dom->id after virDomainCreateWithFlags



On 23.05.2013 15:19, Michal Privoznik wrote:
> On 23.05.2013 02:01, Marek Marczykowski wrote:
>> The same issue as (already fixed) in virDomainCreate -
>> REMOTE_PROC_DOMAIN_CREATE_WITH_FLAGS doesn't return new domain ID, only
>> -1 on error or 0 on success.
>>
>> Besides this one fix it is more general problem - local domain object
>> ID can desynchronize with the real one, for example in case of another
>> client creates/destroys domain in the meantime. Perhaps virDomainGetID
>> should be called remotely (with all performance implications...)? Or
>> some event-based notification used?
>>
>> Signed-off-by: Marek Marczykowski <marmarek invisiblethingslab com>
>> ---
>>  src/remote/remote_driver.c   | 40 ++++++++++++++++++++++++++++++++++++++++
>>  src/remote/remote_protocol.x |  2 +-
>>  2 files changed, 41 insertions(+), 1 deletion(-)
> 
> ACKed and pushed. However, this deserves to be pushed into maint
> branches as well, doesn't it?

Yes, I think so.

-- 
Best Regards,
Marek Marczykowski
Invisible Things Lab

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]